I checked this out and it looks like it runs as expected. There are still a lot of "BASICLTI" references in the code which we might cleanup on a separate issue after this is merged rather than trying to fix it all here. Of these I think only 1 needs to be updated, but that's easy. 2 would be nice to have. 3 sounds like a large project.

1. On the README.md it refers to documents like these, but it looks like these were all renamed

20:* [Sakai API Documentation Including API Extensions](docs/sakai_basiclti_api.md)
22:* [Configuring the Sakai External Tools Portlet](docs/sakai_basiclti_portlet.md)
24:* [Configuring the Sakai LTI Provider](docs/sakai_basiclti_provider)
26:* [Documentation for Vendors of Sakai Tools](docs/sakai_basiclti_vendor.md)

2. All of the variables in lti/lti-common/src/java/org/sakaiproject/lti/util/SakaiLTIUtil.java are still BASICLTI_

3. The tool_id is still sakai.basiclti. To rename this would require changing a lot of things

   • All the names in the config/localization bundles
   • All the value\ in the sitestats Events
   • Likely a database conversion
   • A check in portal
   • The value in the help documentation which is in screensteps
   • Webservices in Sakai Script
   • Icons in the library
   • Some code in lessons would need to change to reference this like

(This might be a separate issue)
4. The values in CC are called "cartridge_basiclti" link and under an imsbasiclti name space. Some of these might not need to change but some of them are wrong and maybe a different issue. It looks like in CC 1.3 they also dropped the "basic" but it's in the for older cartridges.

Lessons has

lessonbuilder/tool/src/java/org/sakaiproject/lessonbuildertool/cc/Ns.java
226:    resourceTypes.put("imsbasiclti_xmlv1p3", BLTI);

But that should be imslticc_v1p3 for 1.3 and NS there doesn't exist. I'm not sure where else that is being used and maybe the export needs to be updated to this version? I don't remember if Sakai 100% supports IMS CC 1.3 or not, but looks like there was some support.

@jonespm Thanks for the review. I will definitely do 1 and 2. Issue 3 is very much on purpose and would be another much later JIRA - I wanted to avoid any DB conversion on this JIRA. I don't want to fix 4 in this JIRA - lets make it another JIRA - the switch in IMS world makes things a little trickier and needs to be thought of as not just a "rename" in our code.

this should not be merged until #12843 has been merged

So @ern I agree to delay until after until #12843 has been merged - it is way easier to redo this (because I have scripts) than to redo that PR. Any sense of an ETA?